search

pacstall / pacstall-programs

Pacstall's official program repository
https://pacstall.dev/packages
MIT License
172 stars 134 forks source link

neovim recursively installs #214

Closed Elsie19 closed 3 years ago

Elsie19 commented 3 years ago

Describe the bug When installing neovim, the contents of /usr/src/pacstall/neovim is usr/src/pacstall/neovim

To Reproduce Install neovim

Expected behavior For the contents of /usr/src/pacstall/neovim to contain something like bin/nvim

wizard-28 commented 3 years ago

Most probably this line is the issue https://github.com/pacstall/pacstall-programs/blob/cf92d3d3c5098f1cd8cfeae092fc078b1028ecfc/packages/neovim/neovim.pacscript#L17

The prefix should be the "prefix" not the directory location (which is handled by DESTDIR) Try refactoring the prefix to /usr or /usr/local (The "prefix" of the install), or just leave it blank for the default /usr/local

wizard-28 commented 3 years ago

As a side note, please add the maintainer field to this script, it's missing one.

wizard-28 commented 3 years ago

Closing this, as it's probably fixed in https://github.com/pacstall/pacstall-programs/commit/d126bb68764af68e3de3de9a6bf925a0eb0672c6