search

pacstall / pacstall

An AUR-inspired package manager for Ubuntu
https://pacstall.dev
GNU General Public License v3.0
1.28k stars 46 forks source link

Pacstall does not stay in the same folder between build and install anymore #758

Closed Zahrun closed 1 year ago

Zahrun commented 1 year ago

@wizard-28 It seems latte-dock-git does not build anything anymore

Zahrun commented 1 year ago

Thank you for the commit. I still get missing dependencies, it seems latte-dock.log

wizard-28 commented 1 year ago

Thank you for the commit. I still get missing dependencies, it seems latte-dock.log

Does latte dock work?

Zahrun commented 1 year ago

No it’s not building it seems

Elsie19 commented 1 year ago

Based on the log you sent, it is building and installing.

wizard-28 commented 1 year ago

The installation was successful, as per your logs

Zahrun commented 1 year ago

It installs without building, then I get command not found: latte-dock image

Elsie19 commented 1 year ago

Why doesn't cmake fail if the dependencies weren't satisfied?

Zahrun commented 1 year ago

What is this in the logs?

    [>] Running install
cat install.sh >install 
chmod a+x install
Elsie19 commented 1 year ago

Not sure

wizard-28 commented 1 year ago

[�[1;34m>�[0m] Running install cat install.sh >install chmod a+x install

It's the ANSI color encoded text I believe, you can cat the log file, to see the colors

Zahrun commented 1 year ago

I meant more the two other lines. I found out the issue. pacstall runs install() in the latte-dock git folder instead of inside thatSameFolder/build

Zahrun commented 1 year ago 
:/tmp/latte-dock master ± sudo make install DESTDIR=target
cat install.sh >install 
chmod a+x install

vs

/tmp/latte-dock/build master ± sudo make install DESTDIR=target
[  1%] Generating mo...
[  1%] Built target pofiles-25ec4fa72206eab41621582ad7d80ee6
[  2%] Generating ts...
[  2%] Built target tsfiles-25ec4fa72206eab41621582ad7d80ee6
wizard-28 commented 1 year ago

I meant more the two other lines. I found out the issue. pacstall runs install() in the latte-dock git folder instead of inside thatSameFolder/build

so cd-ing into build/ fixes it?

Zahrun commented 1 year ago

Yes. I remember we had a similar issue in the 3.0.0 pacstall version

Zahrun commented 1 year ago

cf. https://github.com/pacstall/pacstall-programs/pull/1682

wizard-28 commented 1 year ago

Okay, so this seems like a pacstall bug, @Henryws is working on a fix.

Elsie19 commented 1 year ago

I added a cd build/ to install()

Zahrun commented 1 year ago

I added a cd build/ to install()

So the solution is to change all pacscript which needs to stay in the same folder to use cd? Other packages are affected like obs-backgroundremoval

Zahrun commented 1 year ago

@Henryws cf. https://github.com/pacstall/pacstall-programs/pull/2101 , pacstall/pacstall-programs#2102 Other packages might also have been broken by the change

Zahrun commented 1 year ago

kalendar-git also affected https://github.com/pacstall/pacstall-programs/pull/2104

Elsie19 commented 1 year ago

I've done more digging and it seems that we're not going to be able to "fix" this issue. Basically from here on out we must treat each function used as if it were starting back at the build directory.

Zahrun commented 1 year ago

Ok then let’s make the changes to the pacscripts 👍