search

pacstall / pacup.py

Help maintainers update pacscripts
GNU General Public License v3.0
12 stars 3 forks source link

fix(deps): Fix `poetry install` #273

Closed malmeloo closed 6 months ago

malmeloo commented 8 months ago

Fixes poetry install by constraining the pyinstaller build dep to python <3.13.

Poetry suggests to fix this by changing the supported Python version to >=3.10,<3.13, but I don't think it's desirable to limit future version support to how quickly Pyinstaller updates.

Elsie19 commented 8 months ago

Is this in relation to the recent PR @srd424 made?

malmeloo commented 8 months ago

I don't think so? But the issue it fixes can be observed in #267 and #268. This simply doesn't install pyinstaller for >=3.13 because it doesn't indicate support for those versions.

Elsie19 commented 8 months ago

@D-Brox I need your opinion as you're the only python guy at the moment.

srd424 commented 8 months ago

Someone who actually understands the python ecosystem should probably look at why #271 works some time :) In particular I suspect a proper review of the anyio / httpcore / httpx versions etc. would fix things "properly."

Elsie19 commented 8 months ago

True, our main guy @wizard-28 who's in charge of pacup has been gone for a hot minute so pacup has had basically no development since he went.

malmeloo commented 8 months ago

I will take a look at it today or tomorrow.

malmeloo commented 8 months ago

...or now :-)

That error is a bug in httpx which is fixed in the latest version: https://github.com/encode/httpcore/issues/825

If you merge this PR and then rebase + merge #216, it will be fixed. I just tested it and can confirm it now works on 3.10.

Elsie19 commented 7 months ago

@D-Brox you can handle this PR, idk much about python dependencies and stuff like that.

Elsie19 commented 6 months ago

Hey so quick update @malmeloo, we've decided, to rewrite pacup in Perl. So we won't have to deal with python issues anymore 😁, along with it being much easier to interface with bash.

malmeloo commented 6 months ago

Yes I've been lurking in the discord and following along somewhat, nice! I'm sure that's gonna be way nicer than the cursed pacscript parser pacup has now.