search

pacstall / pacup

Help maintainers update pacscripts (next-gen Perl rewrite)
GNU General Public License v3.0
5 stars 2 forks source link

git commit versions are treated as newer #13

Closed vigress8 closed 3 months ago

vigress8 commented 4 months ago

Describe the bug

dpkg can judge git commit versions fetched from repology (e.g. 165997c4) to be newer than semver values (e.g. 1.1.12), which is usually undesirable.

To reproduce

pacup obs-backgroundremoval

Expected behavior

git versions should ideally be ignored

Screenshots

[+] INFO: Parsing .SRCINFO for obs-backgroundremoval.pacscript
    [>] Found pkgname: obs-backgroundremoval
    [>] Found pkgver: 1.1.12
    [>] Found maintainer: Zahrun <Zahrun@github.com>
    [>] Found repology info: project: obs-backgroundremoval
[+] INFO: Querying Repology
** GET https://repology.org/api/v1/project/obs-backgroundremoval ==> 200 OK (1s)
    [>] Current: 1.1.12 ~> Latest: 165997c4
Proceed with updating obs-backgroundremoval to 165997c4? [Y/n]
    [>] Found source https://github.com/royshil/obs-backgroundremoval/archive/refs/tags/165997c4.tar.gz
[+] INFO: Fetching sources for obs-backgroundremoval
[+] INFO: Downloading 165997c4.tar.gz
[!] ERROR: 404 Not Found
[+] INFO: Cleaning up
vigress8 commented 3 months ago

Partially alleviated by #15

oklopfer commented 3 months ago

even more alleviated by https://github.com/pacstall/pacup/pull/17

oklopfer commented 3 months ago

this should no longer be the case with #17 now, going to close.