Closed JP-Ellis closed 1 year ago
I've updated the PR with the following changes:
effort
group of labels as I do think it is overkill for open source projects.cron
schedule to run weekly on downstream repositories, as it is unlikely that labels change all that frequently.I would be pretty keen to see this PR merged. This repository's labels will be updated (hopefully not a big issue), and downstream repositories will not be affected as downstream repositories will need to pull in labels, as opposed to the this repository pushing the labels down.
I would like to start using these labels in the Pact Python repository to start with. This can serve as a more formal test bed, and we can see how well it works.
I have several small things to discuss:
area:upstream
. Is that the source code of the pact-xxx project itself (under src
directory)?status:*
labels seem all have black color.type:bug
and type:fix
the same?Thanks @tienvx for the feedback :)
area:upstream
is to indicate that the issue does exist, but is caused by an underlying issue in a dependency. An example within the Pact ecosystem would be a bug in Pact Python, that upon investigation, is discovered to be a bug in the Rust core.status:*
are indeed black. They render as follows in GitHub:
type:bug
and type:fix
are two aspects of the same coin. One is used for the GitHub issues, and the other is for PRs. Happy to discuss further:
fix
helps line up with the conventional commit typetype:bug
for a PR implicitly indicates that this is a fix.Looks good to me, I would love @sergeyklay to cast his eyes over at some point, as I know he worked recently on the labels in pact-python.
They look pretty aligned, at the moment, as in existing pact-pythons are covered with some additional , which are more related less to an indiv project but more at an org level which make total sense
I thought I would create a draft PR to get the ball rolling for updated labelling of issues. This is definitely intended to be a conversation started, and has been mostly copied from one of my other repos.
This would work as follows:
.github/labels.yml
contains the definition the labelling of issues across the Pact Foundation organisation. The changes are not pushed to each repository, and instead each repository must pull the changes from this repo. This allows each repo to adopt this at their own pace..github/labels.yml
definition which extends this repo's.github/labels.yml
to suite their specific neads.The labels come in broad categories: