Closed YOU54F closed 2 years ago
Windows build failed (as expected), but returned a 0 exit code so build passed (not expected)
https://github.com/pact-foundation/jest-pact/runs/5602022776?check_suite_focus=true
@YOU54F - the windows build is "passing" because github's windows runners don't respect the -eu
in the shebang. We should add:
#!/bin/bash -eu
set -eu
Thanks for the additional comments and eye casting over @TimothyJones , will take them all on board.
@YOU54F - the windows build is "passing" because github's windows runners don't respect the
-eu
in the shebang. We should add:#!/bin/bash -eu set -eu
Thanks Tim, I will cause a failing windows run once I've sorted some of the other comments and ensure this is failing as expected, and will make a note to update other repos ( I took this from mocha-pact )
It would be worth templating these, as they are used across multiple pact foundation repos now
Going to give this a go now 🚀
closes #208