search

pact-foundation / jest-pact

A Pact adaptor for to allow you to easily run tests with Jest
https://pact.io
MIT License
81 stars 12 forks source link

Add Jest@28 to the peer dependencies (and fix a few other issues) #211

Closed TimothyJones closed 2 years ago

TimothyJones commented 2 years ago

I wanted to use jest-pact in a repo that is using Jest@28, but I couldn't, because the peer dependencies don't allow it.

I reviewed the changelog, and we're able to use Jest@28 with no further changes. So I bumped the version, and confirmed that the tests still pass.

I also corrected an import line so that all versions of pact-js supported by jest-pact will work (this fixes a bug, as the latest version of pact didn't work with the current version of jest-pact - not sure when this bug was introduced).

I also fixed up some outdated dependencies.

TimothyJones commented 2 years ago

Also, I noticed that the master build was failing sometimes - looking in to it it's because of a mistake where the beforeAll of both the pact setup and the changing the timeout were at the same level, meaning the timeout wasn't always changed during the setup hook. I fixed that too.

YOU54F commented 2 years ago

Thanks @TimothyJones <3

Will get this out now