Bump Pact version - Githubissues

pact-foundation / jest-pact

A Pact adaptor for to allow you to easily run tests with Jest

https://pact.io

MIT License

81 stars 12 forks source link

Bump Pact version #221

Closed pezholio closed 1 year ago

pezholio commented 1 year ago

Checklist

[x] npm run dist all pass on my machine (The build step fails, but I think this might just be something to do with my local config)
[x] I have followed the commit message guidelines, with messages suitable for appearing in the changelog

Description

Not sure why Dependabot hasn’t spotted this, but there don’t seem to be any breaking changes introduced.

TimothyJones commented 1 year ago

Thanks for the PR! I don't have permissions to merge it, but I gave it a tick 🙌

YOU54F commented 1 year ago

Error: node_modules/@pact-foundation/pact-core/src/types.d.ts(1,8): error TS1259: Module '"/home/runner/work/jest-pact/jest-pact/node_modules/@types/needle/index"' can only be default-imported using the 'esModuleInterop' flag

🤔 - Just about to jump into a meeting, so will take a look at this shortly, but there is an error in the build.

Thanks for the update @pezholio

TimothyJones commented 1 year ago

I think the failed build is actually a problem with pact-core, rather than this repo - it just happens to have been caused because of the bump in version bringing in a different pact-core.

I raised a PR to fix it.

You could also pass this build by putting esModuleInterop: true in the tsconfig.

pezholio commented 1 year ago

@TimothyJones I've made the change to the tsconfig here, so the build should pass now 👍