search

pact-foundation / pact-broker-chart

This repository houses the Pact Broker Helm Chart
MIT License
11 stars 20 forks source link

feat: bumped the version of the Pact Broker to 2.112.0-pactbroker2.107.1 (using the new docker tagging naming convention) #64

Closed sherifkayad closed 1 year ago

sherifkayad commented 1 year ago

feat: bumped the version of the Pact Broker to 2.112.0-pactbroker2.107.1 (using the new docker tagging naming convention)

sherifkayad commented 1 year ago

@ChrisJBurns would you mind having a look at this one? .. I changed the used image tag to match the new standard set in the docker project

My suggestion would be (to keep SemVersioning):

ChrisJBurns commented 1 year ago

Hi @sherifkayad thanks for the PR, when you say right hand side, what do you mean exactly?

Chart versions tend to be loosely coupled (some not related at all) with the underlying application versions. I typically only tend to bump the major Chart versions if I'm introducing a change that will break existing deployments for users. I've not really needed to bump the application versions of the Pact Broker in this Chart for a while because it hasn't required any new resources or had issues with any current resources being created by the Chart. So in order for users to use the latest Pact Broker version they could just set the latest image as a value at install time (we do this in my company with tools like FluxCD and Renovate). Hope this makes sense, I'd still like to merge this PR because although the new Pact Broker image doesn't really require any Chart resource changes, it's good to at least align with the new tag scheme of the image :+1:

sherifkayad commented 1 year ago

@ChrisJBurns thanks for triggering the pipelines. What I meant by left / right hand side was the new naming scheme of the Pact Broker Docker Image and that images would have a version of the Base Docker Image (left hand side part) and concatenated to it the Pact Broker version (right hand side part).

Since a couple of projects now, we only maintain the Chart version and try not to maintain an extra Image Version in each chart (basically we don't override the default Image nor its Version) .. As all of the public Helm Charts bump their Chart version once the application Image is updated. That could be a simpler approach even if one has a Renovate Bot performing the upgrades..

I know that's probably different from the approach you mentioned, however, I believe it's way simpler for users of the Helm Chart.

Maybe a suggestion to make the maintenance of this Helm Chart easier is to connect it to Renovate and configure a semantic helm release Plugin to handle auto bumping the Chart version once the application Image changes .. we kinda do that approach for our internal Helm Charts.

ChrisJBurns commented 1 year ago

@sherifkayad Do you have some code samples of the config needed for renovate? We have Dependabot activated on the repo at the moment, but I've not used it to do what you mentioned? Also, I think this is probably worth a separate issue in itself with the respective PR to add it in. If we can automate the Chart updates with the image updates then that's great.

Do you mind creating an issue describing the fact that we need to automate the Pact Broker image versions updates as well as the relevant Chart updates also?

sherifkayad commented 1 year ago

@ChrisJBurns thanks for merging this PR .. To the Renovate / Dependabot topic:

For that I created #67