pact-foundation / pact-broker-chart

This repository houses the Pact Broker Helm Chart
MIT License
11 stars 20 forks source link

Unable to set ingress path other than / #70

Open manali14 opened 1 year ago

manali14 commented 1 year ago

In ingress there is no way to set any other Prefix other than /, so its difficult to configure pact to a custom path.

Details here: https://github.com/pact-foundation/pact-broker-chart/blob/master/charts/pact-broker/templates/ingress.yaml#L33

In order to get it working, I have to disable ingress from helm chart and create it separately because my pact server is running on a custom path i.e, /pact

ChrisJBurns commented 1 year ago

Hi @manali14

Just looking at this now, would the addition of a pathPrefix value be suffice? An example:

       paths:
          - path: {{ Values.ingress.path }}
            pathType: Prefix

Where ingress.path is defaulted to / for backwards compatibility. You should then be able to use it by passing in ingress.path: "/pact"

tw-kushalbajaj commented 3 months ago

Hi @ChrisJBurns Did we find a way to achieve this without having to add a copy of repo locally ?

ChrisJBurns commented 3 months ago

Hi, I'm awaiting @manali14 response on this one, but in order to get this in, we might have to put a basic working version of an ingress resource in.