search

pact-foundation / pact-go

Golang version of Pact. Pact is a contract testing framework for HTTP APIs and non-HTTP asynchronous messaging systems.
http://pact.io
MIT License
834 stars 104 forks source link

handle tags for pointers #197

Closed soniah closed 2 years ago

mefellows commented 2 years ago

Thanks @soniah, this is 👍 .

We use conventional commits in the repo, which is used to auto-generate release notes. Could you please rebase the change, just rewording your commit?

I'd suggest: fix: support struct tags for pointers.

Once that's sorted, i'll merge and release (assuming of course the build passes).

soniah commented 2 years ago

No worries. I'll get my internal changes merged and released, then amend this commit. Then do our internal stuff to use the mainline repo.

mefellows commented 2 years ago

👍

On Tue, 1 Feb 2022, 2:48 pm Sonia Hamilton, @.***> wrote:

No worries. I'll get my internal changes merged and released, then amend this commit. Then do our internal stuff to use the mainline repo.

— Reply to this email directly, view it on GitHub https://github.com/pact-foundation/pact-go/pull/197#issuecomment-1026451177, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAANFDDVXQIBEVGKIU6NAMLUY5JZTANCNFSM5NH4CDOA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

soniah commented 2 years ago

Matt, I've updated the PR title and force pushed.

On Tue, 1 Feb 2022 at 13:04, Matt Fellows @.***> wrote:

Thanks @soniah https://github.com/soniah, this is 👍 .

We use conventional commits https://www.conventionalcommits.org/en/v1.0.0/ in the repo, which is used to auto-generate release notes. Could you please rebase the change, just rewording your commit?

I'd suggest: fix: support struct tags for pointers.

Once that's sorted, i'll merge and release (assuming of course the build passes).

— Reply to this email directly, view it on GitHub https://github.com/pact-foundation/pact-go/pull/197#issuecomment-1026408473, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAANWJQRGD4SF2ZCOTUGNXTUY45T3ANCNFSM5NH4CDOA . You are receiving this because you were mentioned.Message ID: @.***>

mefellows commented 2 years ago

Sorry to be picky, it's not the PR title but the commit message that needs updating.

i.e. this: Screen Shot 2022-02-03 at 2 27 13 pm

should be something like

fix: support struct tags for pointers

The reason is, the bit before the : is used to determine what goes in the changelog.

mefellows commented 2 years ago

Also don't worry about the failing build. It looks like I need to update some build dependencies, and i'll do that when I migrate to GH actions (as per the 2.x.x branch). I'll merge this in irrespective, but want you to get the commit recognition :)

soniah commented 2 years ago

No worries, done!

On Thu, 3 Feb 2022 at 14:47, Matt Fellows @.***> wrote:

Also don't worry about the failing build. It looks like I need to update some build dependencies, and i'll do that when I migrate to GH actions (as per the 2.x.x branch). I'll merge this in irrespective, but want you to get the commit recognition :)

— Reply to this email directly, view it on GitHub https://github.com/pact-foundation/pact-go/pull/197#issuecomment-1028575216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAANWJQYWW47YN2JY6E2ZCTUZH3GLANCNFSM5NH4CDOA . You are receiving this because you were mentioned.Message ID: @.***>