Allow empty response - Githubissues

stan-is-hate commented 3 months ago

This PR allows empty message responses. One use case is grpc error responses, where you might want to ensure the server responded with no message but just the status.

TODOs:

make sure CI works (avro plugin didn't start correctly on my machine, but might be that it doesn't support arm macs)
~do we want to allow empty responses only when metadata is not empty? and if so, how to do it?~ I think this should be handled in the rust part, not here. Here all we do is decode and pass the message into the test func.
~why aren't matching rules supported in the metadata (might need a separate PR)~ https://github.com/pact-foundation/pact-reference/pull/384
~can this be tested via unit tests~ done, added unit tests
squash commits once reviewed (don't want to squash because changes might be required, wouldn't want to squash again)

coveralls commented 3 months ago

coverage: 37.243% (+0.04%) from 37.2% when pulling 74c30a175ca4fc04430d19a437f7790777e2ddf0 on stan-is-hate:allow-empty into f04022c1c662126bba6e360e999ba29875affe30 on pact-foundation:master.

stan-is-hate commented 3 months ago

I'll close this one if you don't mind - I messed up the rebases and it's more hassle than it's worth to untangle them. I've opened #386 using a patch instead, so that one has a single commit :)

pact-foundation / pact-go

Allow empty response #383