pact-foundation / pact-js-cli

The Broker CLI for Pact, but available to your node scripts
MIT License
1 stars 1 forks source link

[Github Workflow] Make standalone update PR run the build #5

Open TimothyJones opened 2 years ago

TimothyJones commented 2 years ago

When the Ruby standalone is updated, we get an automated PR (for example https://github.com/pact-foundation/pact-js-core/pull/336). The trigger for this PR is this workflow: https://github.com/pact-foundation/pact-js-core/blob/master/.github/workflows/update.yml, which runs this script: https://github.com/pact-foundation/pact-js-core/blob/master/script/create-pr-to-update-pact-ruby-standalone.sh

At the moment, the build and test workflow isn't kicked off when that PR is made (by default github doesn't run triggers automatically on PRs made during a workflow- I think this is to avoid accidentally creating an infinite loop). This means that we don't get feedback on the build unless we manually run it, or merge it and later find out that it's broken.

It would be an improvement to make the automatically submitted PR run the build and test workflow. I'm not sure what is required to do this - possibly modifying the permissions in the update workflow, or in the script that makes the PR?