search

pact-foundation / pact-js-cli

The Broker CLI for Pact, but available to your node scripts
MIT License
1 stars 1 forks source link

Improve error message when project names contain spaces #7

Open TimothyJones opened 3 years ago

TimothyJones commented 3 years ago

Similarly to pact-foundation/pact-js-cli#6, when the path contains a space, the ruby binaries don't work (#247). The error message is consistent and unhelpful.

We could detect this error message and recommend a fix / link to the docs.

A generic framework for detecting common errors and recommending fixes would be useful.

mefellows commented 1 year ago

I think this is resolved now by removing Ruby.

TimothyJones commented 1 year ago

Is Ruby removed? I thought it was still used for the CLI?

mefellows commented 1 year ago

Yes we still expose the binstubs, but I don't think we should change the behaviour of those.

I left another issue open that leaves this possibility open, however. I'm going to remove the remaining non FFI (i.e. Ruby) wrapper code in the next major version as we no longer have any major driver to continue to support those functions.

TimothyJones commented 1 year ago

I meant that this issue will affect the binstubs too.

I think it's really good to have the CLI wrapped in an npm package - it would be great to have that alive somehow even if they're removed from the main one.

mefellows commented 1 year ago

Ah yes, I suppose we can consider it alongside pact-foundation/pact-js-cli#6. I think at this moment bringing the binaries in the package is convenient (I'm not proposing we remove them), but doing anything more than that might be beyond what we should be doing here in this package.