Closed TimothyJones closed 1 year ago
Looks like this build is failing for the same reason that master is failing. I'll wait for a maintainer to look in to that 😝
Thanks Tim. I brought in a bunch of the dependency updates to the examples, but looks like it 💥 .
They are getting a little unwieldy now and I've been thinking if we need to take a different route (the majority of build time now is running these "integration" examples, and I'm becoming increasingly convinced there is probably a better path forward here).
But that aside, this is much appreciated and makes sense - thanks!
npm run dist
works locally (this will run tests, lint and build)PR Template
This PR removes an unnecessary
@types/bluebird
dependency. When looking in to whether or not Pact is actually using bluebird, I noticed that it was, but that it wasn't necessary. So I removed it.This PR replaces Bluebird with native promises.
There is one small behaviour change - this change will no longer run the localhost port checks sequentially. I don't think this is actually necessary, since we're only checking if any one of them passes, it won't matter if
127.0.0.1
andlocalhost
collide.Also, I noticed the tests are hanging at
TRACE (72171): pact@10.3.1: Verification completed, closing server
for about 30 seconds. I don't know why this is, but it was happening in master too, so I ignored it.