Remove most lint directives

[TimothyJones]

This PR removes almost all lint directives from the source. Each commit is reasonably self-contained, so you could cherry-pick if you don't want some of them.

Key points:

• The typescript type checker was explicitly turned off (!) in a few files. This is not a good idea, as it means that land mines and maintainability issues are left for future developers
• Some private properties are relied on in tests. Since most of these were on the new data classes, I just made the data class properties public.
• Some tests either used incomplete mocks, or wrote to private properties. I left those with TODO comments
• I didn't touch V4 because it looks like it's work in progress.
• The javascript eslint settings are not disabled by the corresponding typescript rules for some reason. This is annoying, as it means there are two settings for the same rule in the rules file. This should be fixed, but it's out of scope for this PR.
• Almost all lint directives were unnecessary

[TimothyJones]

Update: I fixed the duplicate rules problem by using the appropriate typescript lint settings. This brought in some new rules about dependency cycles and use-before-define, so I fixed those too. I don't think they're actually problems with the current versions of node, but it's still good to be standards compliant.

Also, I removed eslint-plugin-prettier since it wasn't used (pact uses the config instead). Using both is a common mistake - for those playing along at home:

• the plugin is to make the linter do prettier formatting (Pact did not do this)
• the config is to stop the linter conflicting with prettier (Pact did do this)

Using the config (with prettier run separately on save) is a nicer developer experience because it means that you only get red squiggles in the editor if you're typing code that isn't right, rather than whenever the formatter hasn't been run.

[mefellows]

Update: I fixed the duplicate rules problem by using the appropriate typescript lint settings. This brought in some new rules about dependency cycles and use-before-define, so I fixed those too. I don't think they're actually problems with the current versions of node, but it's still good to be standards compliant.

Also, I removed eslint-plugin-prettier since it wasn't used (pact uses the config instead). Using both is a common mistake - for those playing along at home:

• the plugin is to make the linter do prettier formatting (Pact did not do this)
• the config is to stop the linter conflicting with prettier (Pact did do this)

Using the config (with prettier run separately on save) is a nicer developer experience because it means that you only get red squiggles in the editor if you're typing code that isn't right, rather than whenever the formatter hasn't been run.

Right, this explanation made sense. I think in the early days, we must have had some eslint rules that were constantly fighting with prettier. I'm pretty sure I introduced prettier, and this was the solution I ended up with.

But what I really want is this:

• lint - find bugs, don't concern itself with styling
• prettier - make the code look the same, no matter who writes it. Remove arguments about opinions (except semicolons of course 😆 )

[TimothyJones]

But what I really want is this:

• lint - find bugs, don't concern itself with styling
• prettier - make the code look the same, no matter who writes it. Remove arguments about opinions (except semicolons of course 😆 )

I agree. This is the current state of pact linting (except for nestjs-pact, which has the conventions it was written with before it moved to pact-foundation)

The defaults for prettier include semicolons, of course ;)