pact-foundation / pact-js

JS version of Pact. Pact is a contract testing framework for HTTP APIs and non-HTTP asynchronous messaging systems.
https://pact.io
Other
1.62k stars 344 forks source link

Value of engines is incorrect in package.json #1028

Closed TimothyJones closed 1 year ago

TimothyJones commented 1 year ago

Software versions

Please provide at least OS and version of pact-js

Please confirm the following:


Pact is only built on node 14+, but the value of engines in package.json is only node 10+. These should match - although fixing it is technically a breaking change.

Also, a breaking change in Pact-JS@10 was to drop support for node below node 10, but that didn't make it into the release notes.

(I recommend supporting only the current versions of node - at this time 14, 16, 18, and optionally 19)