chore: Update dependencies to fix #1029

pact-foundation / pact-js

JS version of Pact. Pact is a contract testing framework for HTTP APIs and non-HTTP asynchronous messaging systems.

https://pact.io

Other

1.62k stars 344 forks source link

chore: Update dependencies to fix #1029 #1035

Closed TimothyJones closed 1 year ago

TimothyJones commented 1 year ago

This PR:

Fixes #1029 by removing (as far as I can tell) unused dependencies
Runs audit fix on all examples that currently pass without changes
Substantially improves the run audit fix on examples script to:
- Keep going when an example fails, since the others might pass
- Also print out the results of npm audit
- Better separate the examples in the log
- Print a list of all the failed updates at the end

Screenshot attached:

TimothyJones commented 1 year ago

The tests pass locally. However, the issue highlighted by https://github.com/pact-foundation/pact-js/pull/1034 is still present, so we can't see the output from the build.

mefellows commented 1 year ago

Thanks Tim! I'm wary of the audit changes with respect to the examples (build failures unlikely to relate to PRs), however, this improves the current situation so worth doing for now until we find a better solution to the example problem.

TimothyJones commented 1 year ago

I think the examples just need to be maintained. Probably most of them can be killed- like, nowadays you could just do typescript for all, which would kill the need for the “typescript” standalone example. Making all of them end to end would also remove the need for “e2e”