pact-foundation / pact-js

JS version of Pact. Pact is a contract testing framework for HTTP APIs and non-HTTP asynchronous messaging systems.
https://pact.io
Other
1.59k stars 343 forks source link

'log' does not exist in type 'PactV3Options' #1080

Closed stevenKirill closed 1 year ago

stevenKirill commented 1 year ago

Software versions

Issue Checklist

Please confirm the following:

Expected behaviour

correct type fot log property

Actual behaviour

log doesn't exist

Steps to reproduce

export const provider = new PactV3({ consumer: 'gpb-expert-consumer', provider: 'gpb-expert-provider', logLevel: 'info', log: path.resolve(process.cwd(), 'logs', 'pact.log'), dir: path.resolve(process.cwd(), 'pacts'), spec: SpecificationVersion.SPECIFICATION_VERSION_V2, });

Relevan

Screenshot 2023-03-31 at 16 09 37

t log files

mefellows commented 1 year ago

Yes, Log doesn't exist on that type. Have we documented it somewhere that we have?

mefellows commented 1 year ago

There is an open feature request for logging to file here: #954. Closing this (unless it's a different big/feature, please reopen and clarify if that's the case).

TimothyJones commented 1 year ago

The missing log parameter isn't mentioned in the migration instructions.

It looks like the migration instructions aren't a distillation of the notes on breaking changes - for example, the verifier instructions say no changes required, but there were actually several changes to the options detailed here

mefellows commented 1 year ago

Yes that's a good point, i'll raise a separate tracking issue for that now.