search

pact-foundation / pact-js

JS version of Pact. Pact is a contract testing framework for HTTP APIs and non-HTTP asynchronous messaging systems.
https://pact.io
Other
1.58k stars 343 forks source link

fix: update pact core dependency #1165

Closed miguelci closed 5 months ago

miguelci commented 5 months ago

PR Template

Update the pact-core dependency to their last version. https://github.com/pact-foundation/pact-js-core/releases/tag/v14.0.6

There was a fix on one of its updates on the fromProviderState function that might fix an issue mentioned in https://pact-foundation.slack.com/archives/C9VBGLUM9/p1705297213981799?thread_ts=1704896397.421819&cid=C9VBGLUM9

miguelci commented 5 months ago

can someone confirm if the fails are related to some issue in the server or to the change?

mefellows commented 5 months ago

This PR isn't really needed, as the dependency in the package.json allows patch version updates. If you need the latest, the simplest thing to do is an npm update @pact-foundation/pact in the project and you should get the latest.

can someone confirm if the fails are related to some issue in the server or to the change?

hmm that is a curious failure, I've actually never seen it before. I'll see if I can reproduce locally.