Closed YOU54F closed 8 months ago
Thanks Saf. I can't comment as to whether that's correct or not, would need to dive into it a bit more. It could be that because the latter version of the matt
plugin uses a latter Plugin interface that corrected a bug?
UPDATE: looked at the Matt plugin, nothing in there that would change that. I suspect it's an internal change (in the core) to how the library works.
UPDATE: looked at the Matt plugin, nothing in there that would change that. I suspect it's an internal change (in the core) to how the library works.
Yeah I need to go digging in the core release notes and check if that is intentional and on the end user / plugin author to update or if its a regression. Will cover that yak shave shortly :) I can replicate the same in pact-go, which is on 0.4.5 currently, and its easier to do so, as it doesn't use an intermediary like pact-js relies on pact-js-core, so I can pinpoint which release introduced it, and work out what we need to do about it from there :)
Issue found
Unrelated to this upgrade but I've noted the following, demonstrated in this commit which passes CI.
V4 Plugin provider verification test fails between pact-js 11.x (11.0.2) and 12.x (12.0.0)
The difference being 11.x has
interactions[0].request.contents.encoded
as false The difference being 12.x hasinteractions[0].request.contents.encoded
as base64with
interactions[0].request.contents.content
being base64 encoded in 12.x11.0.2