Closed harris-linktree closed 2 years ago
@mefellows: Since this was my code, I'll add some context. I believe this issue is in the Rust verifier.
The argument is mapped here:
The flag mapper is here:
https://github.com/pact-foundation/pact-js-core/blob/master/src/verifier/argumentMapper/index.ts#L71
And the definition of the argument in the rust source is here:
My understanding at the time of implementing the argument mapper was that the Verifier CLI treats all booleans as false by default. If the Verifier CLI is updated to support --no-publish
or --publish=false
, then here is where the corresponding change in pact-js would go.
Thanks for raising Harris and for that context Tim. Should be an easy one to squash in the next week.
I'm traveling at the moment in the US so likely I won't be able to get to this until next week
This should be fixed in the latest release (v10.0.1) - can you please check?
This should be fixed in the latest release (v10.0.1) - can you please check?
yeap it is fixed thanks Matt :)
Great, thanks for confirming!
publishVerificationResult
always pushes the contract to the broker even if it is set asfalse
. However, V2, config works as expected.Software versions
Issue Checklist
Please confirm the following:
Expected behaviour
When I set
publishVerificationResult
to false, it should not upload contracts to the brokerActual behaviour
When I set
publishVerificationResult
to false, it uploads contracts to the brokerSteps to reproduce
true
and run test to confirm pact uploadedfalse
and run test to confirm pact uploaded or not