search

pact-foundation / pact-js

JS version of Pact. Pact is a contract testing framework for HTTP APIs and non-HTTP asynchronous messaging systems.
https://pact.io
Other
1.63k stars 347 forks source link

fix: PactV4 error handling logic #942

Closed mefellows closed 2 years ago

mefellows commented 2 years ago

See repro here: https://github.com/lennartquerter/pact-v3-test

TimothyJones commented 2 years ago

Good find and fix. Sorry if this was my fault.

This is a good candidate for sticking to the changelog guidelines - the issue with developer-centric commits is that the changelog for this release isn't very friendly for users, since it just says "PactV4 error handling logic".

I reckon something like fix: Correct an issue that caused certain tests to fail with "Error in native callback" would have been better.