Is `"min": 0` needed in matchers generated by Consumer PactDSL? (GroovyDSL doesn't use it)

tlinkowski commented 3 years ago

Current status

Right now:

PactDSL generates an extra "min": 0 entry on calls to each*Like methods (source)
while GroovyDSL does no such thing (source)

Example:

Pact DSL: new PactDslJsonBody().eachLike("values", stringType("example")) generates

"$.values": {
 "matchers": [{"match": "type", "min": 0}],
 "combine": "AND"
}
"$.values[*]": {
 "matchers": [{"match": "type"}],
 "combine": "AND"
}

Groovy DSL: { values eachLike(string('example')) } generates

"$.values": {
 "matchers": [{"match": "type"}],
 "combine": "AND"
}
"$.values[*]": {
 "matchers": [{"match": "type"}],
 "combine": "AND"
}

Consequences

Apart from the obvious (and unintuitive) discrepancy between PactDSL and GroovyDSL, the main drawback is that Pact Broker does not render the content of such eachLikes when it renders them.

That is, instead of:

"values": [
  "example"
]

Pact broker renders:

"values": [
]

which makes the preview in Pact Broker very much useless 😞

Question

Can the following occurrences of matchMin(0) below be replaced with TypeMatcher.INSTANCE?

Would you accept a PR with such a change?

uglyog commented 3 years ago

PRs are always welcome, but in this case it was a small change so I just did it.

uglyog commented 3 years ago

4.1.17 has been released

pact-foundation / pact-jvm