Closed f1337 closed 3 years ago
Thanks for the PR. Just had a quick look at the CHANGELOG.md for 1.0.0, and it has the following:
Deprecate relying on default exit_on_failure?. In preparation to make Thor commands exit when there is a failure we are deprecating defining a command without defining what behavior is expected when there is a failure. To fix the deprecation you need to define a class method called exit_on_failure? returning false if you want the current behavior or true if you want the new behavior.
Could you please add the following to the commands, and make sure there is no deprecation warning?:
def exit_on_failure?
false
end
Personally I think it should exit on failure, it's just that I'm not sure about any unforeseen side effects, and don't want to put that burden of testing on you!
@bethesque Done! Please let me know if there's any other changes you'd like me to make. 😸
Once this PR looks good to you, I will happily apply the same changes to the pact-ruby
PR.
Thank you!
Thank you kindly.
Thor
1.0
is out, and we're using it with Pact on https://github.com/department-of-veterans-affairs/vets-api.But we're having to maintain a fork to do so. This PR bumps the Thor dependency with a
< 2.0
max, imitating recent versions of Railties.Feedback is welcome. Thank you!