search

pact-foundation / pact-mock_service

Provides a mock service for use with Pact
https://pact.io
MIT License
73 stars 69 forks source link

use ssl when checking if https server is up #52

Closed sk1talets closed 8 years ago

sk1talets commented 8 years ago

Updated WaitForServerUp to use SSL if mock service was started with --ssl option. Currently it fails after 100 failed http get checks.

bethesque commented 8 years ago

Code looks good, just trying to work out why the build failed.

bethesque commented 8 years ago

Ah, right.

Gem::InstallError: rack requires Ruby version >= 2.2.2. Using webmock 1.18.0 Gem::InstallError: activesupport requires Ruby version >= 2.2.2.

bethesque commented 8 years ago

I'll merge it because the code change hasn't affected the build status. Thanks!

bethesque commented 8 years ago

@sergei-matheson can you do a release? My ruby env is out of date and throwing errors when try and bundle install.

bethesque commented 8 years ago

Released 0.10.2 (considering this a bug fix). Thanks for your work @sk1talets ! Much appreciated. Sorry it took so long to release.