search

pact-foundation / pact-mock_service

Provides a mock service for use with Pact
https://pact.io
MIT License
73 stars 69 forks source link

Fix issue with request body and path matching rules generation #62

Closed MattTYXM closed 7 years ago

MattTYXM commented 7 years ago

Working on fixing specs now. I just started learning ruby yesterday so I apologize for not addressing this before the pull request was created.

UPDATE: tests are passing now

bethesque commented 7 years ago

Sorry @MattTYXM, as mentioned, house move is getting in the way of code time. I have not forgotten about this!

MattTYXM commented 7 years ago

Found another issue where the remove interactions endpoint was not clearing the verified interactions which was causing issues when multiple consumer tests were executed against a single running mock service. I modified the endpoint to consider a "keep_verified" parameter that when true will follow the existing logic and when it is false or not passed ALL interactions are removed.

bethesque commented 7 years ago

Please submit separate PRs for different changes so they can be evaluated separately.

MattTYXM commented 7 years ago

Ok I have separated them into 2 PR’s

On Feb 28, 2017, at 4:12 PM, Beth Skurrie notifications@github.com wrote:

Please submit separate PRs for different changes so they can be evaluated separately.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bethesque/pact-mock_service/pull/62#issuecomment-283161944, or mute the thread https://github.com/notifications/unsubscribe-auth/APQ2muMlqT_OZV2LH6-C_l876bqaqv1gks5rhI2ggaJpZM4MCRcl.