search

pact-foundation / pact-mock_service

Provides a mock service for use with Pact
https://pact.io
MIT License
73 stars 69 forks source link

Fix request decorator #63

Closed MattTYXM closed 7 years ago

MattTYXM commented 7 years ago

@bethesque this pull request along with this one are the PR's that resulted from you requesting that I break them up by bug. I am just looking to find out when these may be considered?

bethesque commented 7 years ago

Thanks for breaking those up, it means questions about one won't block the other.

MattTYXM commented 7 years ago

@bethesque I added specs to support my code changes, I also implemented the code to support query hashes with matchers.

bethesque commented 7 years ago

@MattTYXM are you using the ruby gem directly, or via another wrapper?

MattTYXM commented 7 years ago

@bethesque I have forkerd your pact-mock-service-npm reporsitory as well. There have been no changes there aside from the necessary changes to make it point at my fork of this repo. If and when you get pact-mock-service-npm updated to point at this most recent version of pact-mock_service I will need to pull that in and I'll wipe out my forks.

bethesque commented 7 years ago

Right, so we have a release cascade. I was hoping to do just a beta release, because I'm a bit nervous about this one, as I haven't had time to sit down and generate some pacts with it myself and inspect the differences. I always like to road test critical changes myself before doing a release as I feel I have a responsibility to do safe releases. Do you have any pacts you've generated with your code that you can post for me?

MattTYXM commented 7 years ago

@bethesque I don't have anything I can post publicly but I can try to generate something generic and post it.

bethesque commented 7 years ago

👍