Closed tienvx closed 8 months ago
I'm sorry but I can't review this, it's too much of a sweeping change. Thank you for the summary above, but quite often the bigger picture is failing to emerge for me on this work. Like all long-lived feature branches, it's getting more and more difficult to construct the whole picture of when this merges, {this} is what folks will have to deal with.
I'm so sorry for it. Closing this PR.
I will try with another approach.
This is the first PR https://github.com/pact-foundation/pact-php/pull/494
Pact
class with pact handleVerifyResult
class from compatibility suite tosrc
AbstractDriver
that holdpact: Pact
instanceAbstractMessageDriver
InteractionDriver
verifyInteractions()
now returnVerifyResult
instead ofbool
MessageDriver
SyncMessageDriver
setUp()
byinitWithLogLevel()
andnewPact()
cleanUp()
bydeletePact(pact: Pact)
writePact()
becomewritePact(pact: Pact)
MockServer
start()
becomestart(pact: Pact)
writePact()
to publicverify()
new returnVerifyResult
instead ofbool
The PR is big and I can't split it anymore. I would like to write tests in separate PRs