pact-foundation / pact-php

PHP version of Pact. Enables consumer driven contract testing, providing a mock service and DSL for the consumer project, and interaction playback and verification for the service provider project
Apache License 2.0
273 stars 92 forks source link

refactor: Refactor consumer drivers #493

Closed tienvx closed 8 months ago

tienvx commented 8 months ago

The PR is big and I can't split it anymore. I would like to write tests in separate PRs

Lewiscowles1986 commented 8 months ago

I'm sorry but I can't review this, it's too much of a sweeping change. Thank you for the summary above, but quite often the bigger picture is failing to emerge for me on this work. Like all long-lived feature branches, it's getting more and more difficult to construct the whole picture of when this merges, {this} is what folks will have to deal with.

tienvx commented 8 months ago

I'm so sorry for it. Closing this PR.

I will try with another approach.

This is the first PR https://github.com/pact-foundation/pact-php/pull/494