test: Test Verifier - Githubissues

pact-foundation / pact-php

PHP version of Pact. Enables consumer driven contract testing, providing a mock service and DSL for the consumer project, and interaction playback and verification for the service provider project

Apache License 2.0

271 stars 92 forks source link

test: Test Verifier #516

Closed tienvx closed 6 months ago

tienvx commented 6 months ago

Remove return $this
Use mocks in VerifierTest

Lewiscowles1986 commented 6 months ago

This is quite the change to usage to go from self to void, especially with a builder pattern.

tienvx commented 6 months ago

They are all private methods. They are not belong to builder pattern. They can be called in any order (except newHandle need to be called first to get the handle of course).

Other public methods (addFile, addDirectory, addUrl, addBroker, verify) are not changed.