search

pact-foundation / pact-php

PHP version of Pact. Enables consumer driven contract testing, providing a mock service and DSL for the consumer project, and interaction playback and verification for the service provider project
Apache License 2.0
273 stars 92 forks source link

test: Test FFI Client #528

Closed tienvx closed 8 months ago

tienvx commented 8 months ago

The purpose of this test is only to increase code coverage

Lewiscowles1986 commented 8 months ago

Right but in this case it's nonsense coverage. If you were to run infection over this type of coverage it might still be low, because as one of the tests states, there are no assertions. We're simply expecting that calling something won't explode.

tienvx commented 8 months ago

Replaced pactffi_string_delete by pactffi_check_regex which return a result. Added an assertion to assert the result. Does it look a bit better?