search

pact-foundation / pact-php

PHP version of Pact. Enables consumer driven contract testing, providing a mock service and DSL for the consumer project, and interaction playback and verification for the service provider project
Apache License 2.0
271 stars 92 forks source link

docs: Code block is not formatted #609

Closed tienvx closed 3 months ago

tienvx commented 3 months ago

I'm not sure why php code blocks are not formatted as expected:

https://docs.pact.io/implementation_guides/php/docs/consumer

Screenshot 2024-05-13 at 3 00 45 PM
YOU54F commented 3 months ago

hmm, we need to add a php to the list

https://github.com/pact-foundation/docs.pact.io/blob/a1898a101283482675d46e9705277facaff87ca3/website/docusaurus.config.js#L199

reference from docusaurus

https://docusaurus.io/docs/markdown-features/code-blocks#supported-languages

YOU54F commented 3 months ago

fixed by https://github.com/pact-foundation/docs.pact.io/pull/320

YOU54F commented 3 months ago

will just need to add new entries in the sync job, for the docs pages that have been newly created as of #612

https://github.com/pact-foundation/docs.pact.io/commit/259c137c06dc99cf5cf896af313fcd57112d63b7#diff-87418f309482244e2599c1a3a1d493ce928e29f3e0901354acf3b27191246137R13

YOU54F commented 3 months ago

new docs added to sidebar in this PR https://github.com/pact-foundation/docs.pact.io/pull/321/files

Netlify is building the site so should be updated in 5/10 mins

YOU54F commented 3 months ago

Fixed, thanks @tienvx