pact-foundation / pact-php

PHP version of Pact. Enables consumer driven contract testing, providing a mock service and DSL for the consumer project, and interaction playback and verification for the service provider project
Apache License 2.0
273 stars 92 forks source link

Revert "deps: Update ffi library to 0.4.20" #615

Closed tienvx closed 5 months ago

tienvx commented 5 months ago

Reverts pact-foundation/pact-php#611

Because of this https://github.com/pact-foundation/pact-reference/issues/416#issuecomment-2111327781

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9097692160

Details


Totals Coverage Status
Change from base Build 9074049712: 0.0%
Covered Lines: 2282
Relevant Lines: 2345

💛 - Coveralls
YOU54F commented 4 months ago

Hey @tienvx ,

Just wanted to show you I got a fix in for the shared lib (building with the latest cross version), and added some content type detection changes in pact-ref. Demoed it in pact-php in the below PR.

https://github.com/YOU54F/pact-php/pull/1/files

Will need to get changes reviewed in pact-ref but wanted to let you know!

tienvx commented 4 months ago

Great news. I can't wait to apply it to pact-php and release another beta for it.