pact-foundation / pact-plugins

🏰 Architecture to support Plugins πŸ”Œ with Pact πŸ”—
MIT License
19 stars 11 forks source link

feat: support tgz for bundled plugins #49

Closed YOU54F closed 10 months ago

YOU54F commented 10 months ago

closes #48

This feels like the code could be dry'd a bit, maybe doing a seperate file extension lookup, then checking the naming convention, then offloading to the correct downloader, but possibly fine for now.

can be tested by

git@github.com:pact-foundation/pact-plugins.git
git checkout feat/targz_plugin_binaries
cd cli
cargo run install https://github.com/austek/pact-avro-plugin/releases/tag/v0.0.4

This will fail, is run from master or from the released binary

pact-plugin-cli install https://github.com/austek/pact-avro-plugin/releases/tag/v0.0.4
github-actions[bot] commented 10 months ago

Unit Test Results

6 tests  Β±0   6 :heavy_check_mark: Β±0   7s :stopwatch: +2s 2 suites Β±0   0 :zzz: Β±0  2 files   Β±0   0 :x: Β±0 

Results for commit dd3359c1. ± Comparison against base commit f57ddf3e.

:recycle: This comment has been updated with latest results.

rholshausen commented 10 months ago

The JVM driver will need to be updated to support this as well.