search

pact-foundation / pact-plugins

🏰 Architecture to support Plugins 🔌 with Pact 🔗
MIT License
19 stars 11 forks source link

upgrade to gradle 8 #63

Closed austek closed 3 months ago

austek commented 4 months ago

upgrade to gradle 8 upgrade depencies

YOU54F commented 4 months ago

just pushed under a branch on origin, to see if some of the failures are reltaed to being from an outside PR

https://github.com/pact-foundation/pact-plugins/tree/austek-gradle_8

austek commented 4 months ago

just pushed under a branch on origin, to see if some of the failures are reltaed to being from an outside PR

https://github.com/pact-foundation/pact-plugins/tree/austek-gradle_8

that build only failed because of some Github limits

"message": "You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID 3858:1228:3C7CB28:3CF738A:664CAE33."

YOU54F commented 4 months ago

Yeah they get me everytime if I raise a PR which has a branch on origin, as you get two sets of jobs, and they all publish unit test results back. We should probably update that to not allow it to fail the build, if we are hitting limits.

re-triggered job and they've passed now

Thanks for the change @austek. I'll add Ron as a reviewer as well, but I shall give it an approve

YOU54F commented 4 months ago

I think to get this merged you may want to at least b)

a) squash your commits b) use conventional commit standards (so chore(deps): update jvm driver to gradle 8) etc as they get picked up in the changelogs. (https://github.com/pact-foundation/pact-plugins/blob/main/drivers/jvm/CHANGELOG.md)

Apart from that looks good to me, but I don't often test the consumption of the jvm-driver in pact-jvm so unsure if this may cause an issue for consumers of the jvm-driver

YOU54F commented 4 months ago

ty Ali!

austek commented 3 months ago

@rholshausen is this something you'd like to get merged, if not, I'll close the PR

YOU54F commented 3 months ago

Hmm has this already been cherry picked here in master

https://github.com/pact-foundation/pact-plugins/commit/5a8e1df161fe7707146ea06b31588b35e9af2d08

rholshausen commented 3 months ago

I thought I modified the PR and then merged. But I guess it is see it as a new commit and still labels it as unmerged.

YOU54F commented 3 months ago

Tres bizarre! Thanks @rholshausen and @austek 💛