Throwing Rust Exception during Provider Validation

chrisgodsey commented 1 year ago

Thank you for reporting a bug! We appreciate it very much. Issues are a big input into the priorities for Pact-JS development

All italic text in this template is safe to remove before submitting

Thanks again!

Software versions

Please provide at least OS and version of pact-js

OS: Windows 10.0.19044
Consumer Pact library: Pact JS 10.1.4
Provider Pact library: Pact JS 10.1.4
Node Version: 16.16.0

Issue Checklist

Please confirm the following:

[x] I have upgraded to the latest
[x] I have the read the FAQs in the Readme
[x] I have triple checked, that there are no unhandled promises in my code and have read the section on intermittent test failures
[ ] I have set my log level to debug and attached a log file showing the complete request/response cycle
[ ] For bonus points and virtual high fives, I have created a reproduceable git repository (see below) to illustrate the problem

Expected behaviour

My validation should complete and give me a result based on the state of my pact one way or another.

Actual behaviour

I receive the following Rust exception. It looks like this exception gets thrown after the validation of everything in my response body:

2022-11-10T20:49:15.773684Z DEBUG ThreadId(01) verify_interaction{interaction="a request with a country code exactly three characters long"}: pact_matching::json: compare_values: Comparing 'Number(1)' to 'Number(1)' at path '$.totalPages' -> Ok(()) thread '<unnamed>' panicked at 'index out of bounds: the len is 1 but the index is 1', pact_matching\src\headers.rs:22:45 note: run withRUST_BACKTRACE=1environment variable to display a backtrace

Steps to reproduce

Walking through this with one of the people in the Slack, it looks like the end cause of my issue was that in my expected response headers, I fatfingered and typed:

                        headers: {
                            'Content-Type': 'application/json;'
                        }

Note the semi-colon at the end of this string. Upon removing this semi-colon, and re-publishing the pact my provider was able to properly verify.

I'd expect, if nothing else, simply informing me of a mismatch in my validation, or a more informative error letting me know if this input error.

TimothyJones commented 1 year ago

According to the http spec, the parameter after the semicolon is optional, so pact should not fail on application/json; - see https://httpwg.org/specs/rfc9110.html#rule.parameter

Of course, even if it were malformed, it would be a nicer experience if pact didn't explode and instead warned.