search

pact-foundation / pact-reference

Reference implementations for the pact specifications
https://pact.io
MIT License
91 stars 46 forks source link

feat: get a generator/matching rule from JSON #232

Closed mefellows closed 1 year ago

mefellows commented 1 year ago

I haven't tested the generator function yet, but the matching rule function works nicely.

This enables me to pull them out from the following plugin RPCs:

And therefore would solve the problem for a content matcher plugin, but not a transport one.

i.e. it won't work for the methods that accept the Pact object (e.g. VerifyInteraction or StartMockServer). I had a look at the existing FFI methods, and I don't think there is a way to navigate to a place where you can extract a MatchingRule (that might be possible, and perhaps is a better pathway).

PrepareInteractionForVerification and VerifyInteraction both already have access to the Config struct, and so could use the other FFI methods (e.g. pactffi_parse_matcher_definition(const char *expression)) for this purpose..

So that would leave just StartMockServer lacking a way to get to the expressions.

This can all be worked around by maintaining state of course, but you mentioned this is against the aim of the framework.

What do you think is the best way to make the expressions (in the form of MatchingRules and Generators) available to a Plugin at all stages?

(I also expect the build to fail because the FFI package will need the new functions in the models package)

rholshausen commented 1 year ago

LGTM. I need to think on this a bit more, there must be a better way to support this requirement

mefellows commented 1 year ago

Thanks. Rather than merge this in (and increase the API surface area), should I create an issue out of it so we can track?

The methods themselves aren't exactly problematic, so I guess it wouldn't be the worst thing to bring them in.

I'll take your advice though. No need to rush this.

rholshausen commented 1 year ago

Yeah, ok, let's do that.