pactffi_verifier_add_directory_source does not filter files based on provider name.
Expected:
If using pactffi_verifier_add_directory_source, based on the documentation
Adds a Pact directory as a source to verify. All pacts from the directory that match the
provider name will be verified.
Does this mean any pact files with the name that matchers the provider name in pactffi_verifier_set_provider_info
Does this mean any json files, that contain a provider.name value that matches that set in pactffi_verifier_set_provider_info
I think I would expect
Combination of 1 & 2. Check for pact files matching the name, then introspect into the pact to check for matching provider.name
Check any json file in the directory, and check for provider.name. A user could have a pact file they have shared manually and renamed the file, but not modified the contents.
Actual:
pactffi_verifier_set_provider_info has a name of a provider that does not exist
No pactffi_verifier_set_consumer_filters are applied
pactffi_verifier_add_directory_source selects all pacts for verification
Issue:
pactffi_verifier_add_directory_source does not filter files based on provider name.
Expected:
If using pactffi_verifier_add_directory_source, based on the documentation
pactffi_verifier_set_provider_info
provider.name
value that matches that set inpactffi_verifier_set_provider_info
I think I would expect
provider.name
provider.name
. A user could have a pact file they have shared manually and renamed the file, but not modified the contents.Actual:
pactffi_verifier_set_provider_info
has a name of a provider that does not existpactffi_verifier_set_consumer_filters
are appliedpactffi_verifier_add_directory_source
selects all pacts for verification