pact-foundation / pact-reference

Reference implementations for the pact specifications
https://pact.io
MIT License
91 stars 46 forks source link

fn matcher_from_integration_json in mockserver/bodies.rs doesn't support all MatchingRules #247

Closed orj closed 1 year ago

orj commented 1 year ago

fn matcher_from_integration_json in mockserver/bodies.rs doesn't support all MatchingRule types.

v4 Matching rules like server, boolean, statusCode` etc are not supported using the format described in https://github.com/pact-foundation/pact-reference/blob/master/rust/pact_ffi/IntegrationJson.md.

Also, the documentation says pact:matcher:type for date/time values should be datetime but the code uses timestamp.

rholshausen commented 1 year ago

Just a note that matcher_from_integration_json is marked as deprecated and should be replaced with MatchingRule::create.

rholshausen commented 1 year ago

matcher_from_integration_json has now been refactored and supports all matching rules