search

pact-foundation / pact-reference

Reference implementations for the pact specifications
https://pact.io
MIT License
91 stars 46 forks source link

ci(chore) - various updates to replace deprecated action notices and red builds #270

Closed YOU54F closed 1 year ago

YOU54F commented 1 year ago

Hey @uglyog

Noted the CI workflows were throwing a few deprecation notices, and the release workflow was failing on any jobs that were for the ffi, verifier cli, or mock server cli, so this PR add's a few changes to clean up the build

  1. Update actions/checkout@v2 to actions/checkout@v3
  2. Switch deprecated actions-rs/toolchain@v1 with dtolnay/rust-toolchain https://github.com/dtolnay/rust-toolchain as original unmaintained - see issue
  3. Replace marcopolo/cargo@master also unmaintained, and not sure using an action for this adds value based on what we are using from it, with a cargo rust/test/build and setting the working-directory as part of the gh action step value
  4. Remove choco install -y llvm from windows build-chain, llvm is already installed on windows runners https://github.com/actions/runner-images/blob/d8d4d924ad21a8ba4931b2988f74bbb376cad021/images/win/toolsets/toolset-2022.json#L400
  5. replace nightly-2022-12-01 with nightly - fails with updated toolchain actions update, it looks like the underlying reason for it being pinned has been fixed https://github.com/rust-lang/rust/issues/105886
  6. Skip upload release assets on the release workflow, where the tags don't correlate with a step to build artefacts.
rholshausen commented 1 year ago

Nice one!