pact-foundation / pact-reference

Reference implementations for the pact specifications
https://pact.io
MIT License
91 stars 46 forks source link

Verification validation errors aren't logged to console #273

Closed mefellows closed 7 months ago

mefellows commented 1 year ago

When there is a validation error communicating in the "pacts for verification" endpoint, the errors are not printed to the console.

It looks like whoever implemented https://github.com/pact-foundation/pact-reference/pull/79 did not consider this, but also it was not communicated/documented in https://github.com/pact-foundation/pact_broker/issues/307 so 🤷 .

The error structure appears to be:

"errors": {
   "problematic key": [ list of errors ]
}

e.g.

  "errors": {
    "providerVersionBranch": [
      "when pending or WIP pacts are enabled and there are no tags provided, the provider version branch must not be an empty string, as it is used in the calculations for WIP/pending. A value must be provided (recommended), or it must not be set at all."
    ]
  }

See also this thread: https://pact-foundation.slack.com/archives/CLS16AVEE/p1683090830674249

github-actions[bot] commented 1 year ago

👋 Hi! The 'smartbear-supported' label has just been added to this issue, which will create an internal tracking ticket in PactFlow's Jira (PACT-981). We will use this to prioritise and assign a team member to this task. All activity will be public on this ticket. For now, sit tight and we'll update this ticket once we have more information on the next steps.

See our documentation for more information.