pact-foundation / pact-reference

Reference implementations for the pact specifications
https://pact.io
MIT License
91 stars 46 forks source link

Re-enable aarch64-unknown-linux-gnu target for pact_ffi #320

Closed YOU54F closed 9 months ago

YOU54F commented 10 months ago

Tracking issue for work to renable aarch64-unknown-linux-gnu target for pact_ffi

Disabling commit:- https://github.com/pact-foundation/pact-reference/commit/a3025b14b8dbea1afea48ece8fa32cdd6718797d

Apparently this was an issue with Cross.

Things we can try

Testing branch

YOU54F commented 10 months ago

Woop

Passes on cirrus-ci

Artifacts available

https://cirrus-ci.com/task/6716205944274944

Screenshot 2023-09-12 at 18 36 11

No beuno in GHA

https://github.com/YOU54F/pact-reference/actions/runs/6162735670/job/16724837147

Screenshot 2023-09-12 at 18 38 33
YOU54F commented 10 months ago

Unable to build it locally with cross on a m1 pro

rustc --version 
rustc 1.71.0 (8ede3aae2 2023-07-12)
cross --version                                         
cross 0.2.5

error

error: linking with `aarch64-linux-gnu-gcc` failed: exit status: 1
  |
...<many paths>
/target/aarch64-unknown-linux-gnu/release/deps/libpact_verifier.so" "-Wl,--gc-sections" "-shared" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-nodefaultlibs"
  = note: /usr/lib/gcc-cross/aarch64-linux-gnu/5/../../../../aarch64-linux-gnu/bin/ld: GFp_armcap_P: undefined version: 
          /usr/lib/gcc-cross/aarch64-linux-gnu/5/../../../../aarch64-linux-gnu/bin/ld: failed to set dynamic section sizes: Bad value
          collect2: error: ld returned 1 exit status

error: could not compile `pact_verifier` (lib) due to previous errorc
YOU54F commented 9 months ago

Managed to build locally on my MBP, kicked off builds on GHA and they are passing both with stable and nightly channels

artifacts uploaded to each run