pact-foundation / pact-ruby-cli

Amalgamated Pact Ruby CLI
https://pact.io
MIT License
12 stars 15 forks source link

Remove the `-multi` tag from cross-platform images #116

Closed agross closed 12 months ago

agross commented 1 year ago

Why is there a need to append -multi to the tag? If the latest tag would be cross-platform:

YOU54F commented 1 year ago

We are just being cautious in our roll out as the pact-cli and pact-broker images which follow the same pattern are used my many across production workloads.

Once we've assessed usage levels and any issues raised, we will promote to first class (ie without the appended -multi flag.

See here for discussion/agreement on how we would proceed

https://github.com/pact-foundation/pact-broker-docker/pull/123#issuecomment-1534054561

YOU54F commented 1 year ago

users would download the same amount of data from the image registry

no they wouldn't, the images are not the same size, as they are built for different architectures and don't contain the same code...

agross commented 1 year ago

no they wouldn't

docker is smart enough to just pull the parts of the image that match the CPU architecture.

YOU54F commented 1 year ago

that isn't the same amount of data as per your statement.

the amd64 images are tried and tested for many years. the arm64 and arm images are different, and not as rigorously tested.

YOU54F commented 1 year ago

size isn't the issue anyway