pact-foundation / pact-ruby-cli

Amalgamated Pact Ruby CLI
https://pact.io
MIT License
12 stars 15 forks source link

chore: update pact-cli version on image release #120

Closed YOU54F closed 7 months ago

YOU54F commented 11 months ago

hopefully fixes #117

with a workflow dispatch on the release image workflow, defaults INCREMENT to "null" - an actual string, with the words null. This will force the version number to remain the same, but increment the 4, portion of the semver, indicating that no changes occurred to the Gemfile, or no features have been incorporated into the Docker image. It just indicates that its been rebuilt and released.

Screenshot 2023-09-12 at 17 24 03

In the scenario that INCREMENT is set, either by

The following will occur

Screenshot 2023-09-12 at 17 23 17

⚠️ if you note in the above image, the multi manifest images are correctly propagated to all tags, in the below image from the latest release from the pactfoundation, its a bit of a mis-mash. I haven't sussed this out yet, as bar the docker destination I am pushing to, the repos are identical 🤷🏾

Screenshot 2023-09-12 at 17 32 39
bethesque commented 11 months ago

The last numeric portion of the version number is really not needed in this package, and we could just get rid of it. The pact-cli only exists as a docker image, and there is no reason to version the gem updates in a separate mechanism to the image or packaging.

YOU54F commented 7 months ago

Tested this published from test_tag branch and publishing multi manifests with correct tags across all builds so fingers crossed it should all go swimmingly at proper release time (and then I'll delete the test project pictured below)

Screenshot 2024-01-23 at 16 14 43