pact-foundation / pact-ruby-standalone

A standalone pact command line executable using the ruby pact implementation and Travelling Ruby
https://pact.io
MIT License
39 stars 32 forks source link

fix: cp json gemspec reqd post 2.0.4 update #99

Closed YOU54F closed 1 year ago

YOU54F commented 1 year ago

relates to #94

It looks like the file

build/vendor/ruby/2.4.0/specifications/json-2.1.0.gemspec

isn't present in the pkg distributions

pkg/pact/lib/ruby/lib/ruby/gems/2.4.0/specifications/default/json-2.1.0.gemspec

when upgrading post json gem 2.0.3

manually copying in the file worked, so added into the package task.

Not sure what the actual root cause, or change between json gem 2.0.3 to 2.1.0 to have caused this, but now seems to be ok and building with the latest 2.6.3 gem

https://rubygems.org/gems/json/versions

Screenshot 2023-04-05 at 15 35 15 Screenshot 2023-04-05 at 15 35 40

Side note

Updated Dockerfiles to use ruby 2.4.10 (as that is what travelling ruby uses) so assume that should be correct, and also added the platform command for those of us on arm machines

Testing notes

Warrants smoke testing, especially of the packages which use the json gem, which look like pact-mock_service & pact-provider-verifier

YOU54F commented 1 year ago

included in #99