search

pact-foundation / pact-workshop-dotnet-core-v1

A workshop for Pact using .NET Core
Apache License 2.0
76 stars 209 forks source link

fix: Provider error test #19

Closed HugoDoyon closed 2 years ago

HugoDoyon commented 3 years ago

Pact is great but lost hours to figure out why Provider test was always failing.

So here is the fix to issue #18

Microsoft.AspNetCore.Server.Kestrel: Error: Connection id "0HM3LKBBJTAHT", Request id "0HM3LKBBJTAHT:00000001": An unhandled exception was thrown by the application.

System.InvalidOperationException: Synchronous operations are disallowed. Call ReadAsync or set AllowSynchronousIO to true instead.

YOU54F commented 2 years ago

Thanks for this @HugoDoyon, we will need to cascade this change through multiple branches but will test this out and incorporate the changes in soon.

Sorry for the late reply, appreciate you going through the workshop :)

martinagligorova-allocate commented 2 years ago

I went through the workshop and the provider test was continuously failing as well, this code fixed the error - could you please move the PR forward

YOU54F commented 2 years ago

The workshop isn’t actually split into distinct branches. Thanks for testing and confirming @martinagligorova-allocate and thanks for the change @HugoDoyon