pact-foundation / pact-workshop-dotnet-core-v1

A workshop for Pact using .NET Core
Apache License 2.0
76 stars 209 forks source link

Workshop scenario datetime - Update to .NET 6.0.x / Pact-Net 4.5.0 #25

Closed YOU54F closed 1 year ago

YOU54F commented 1 year ago

Hey @tdshipley

Thanks for the awesome workshop,

I've updated it

I need to update the README to reflect the new code snippets.

As an aside, I've also fixed up the https://github.com/DiUS/pact-workshop-dotnet-core-v3 workshop, and I would like to propose something

I have happy to keep both workshops, but would like to move this one either into its own branch, or as an extra course rather than get rid of it.

Will drop a PR shortly for the changes to the canonical example.

tdshipley commented 1 year ago

Thanks for the contribution, Yousaf - it looks excellent and apologies I didn't review it properly in time!

tdshipley commented 1 year ago

@YOU54F Happy to move this one into its folder or branch and make the updated workshop the default.

YOU54F commented 1 year ago

Thanks buddy and no problem 👍🏾 happy to fix any more issues going forward but at least this moves us forward a bit, appreciate the reply