feat: Auto detect commit sha, add shorthand -r flag

pact-foundation / pact_broker-client

A Ruby and CLI client for the Pact Broker. Publish and retrieve pacts and verification results.

MIT License

69 stars 48 forks source link

feat: Auto detect commit sha, add shorthand -r flag #119

Closed YOU54F closed 1 year ago

YOU54F commented 2 years ago

resolves #100

Make --auto-detect-version-properties pick up both the git commit, and git branch, from available env known CI env vars , or git commands if in a git repo.
Adds shorthand -r flag

Would love to make default behaviour, but in lieu of that I used the shorthand flag for -r for recommended :)

Should fit in nicely with our re-work of the path to nirvana

bethesque commented 1 year ago

Ping me when you're happy with this.

YOU54F commented 1 year ago

Hiya Beth, sorry for late reply, haven’t had the headspace to jump back on this at the moment, but will make the logic less complex and meet your wish list.

i’ll be sure to give you a holla so we can tee this up with some docco changes to recommended workflows ( and box off the path to nirvana updates for branches / envs )

bethesque commented 1 year ago

Can you have a poke around and see if you can do the same for the build URL?

YOU54F commented 1 year ago

Can you have a poke around and see if you can do the same for the build URL?

yeah sure thing, I already know some of them from previous work on a slack reporter for cypress

https://github.com/YOU54F/cypress-plugins/blob/8c559869f3cadc0599eadae980d73472580d2077/cypress-slack-reporter-old/src/slack/slack-alert.ts#L735-L799

YOU54F commented 1 year ago

Should be good for review again now, have moved out the DX instructions to #143

bethesque commented 1 year ago

This must be the longest running most painful PR ever. My sincere apologies.

I've removed all the "version_required" and "explicit auto detect" code. It wasn't being used, and was just complicating things. Sorry you had to try and reverse engineer that.
auto detect now includes the build URL along with the commit and branch
raise errors in publication task and publish command if no consumer version is specified/found

bethesque commented 1 year ago

Thank you for your patience and perseverance with this @YOU54F! We got there in the end 😆

YOU54F commented 1 year ago

yay and no problem @bethesque - thanks for the guidance as always and also thank you for wrapping up the last bits 🥰

mefellows commented 1 year ago

WOOT - better later than never hey!

bethesque commented 1 year ago

Unfortunately, it's not going to be much use to the people using the docker image, because you have to map the env vars deliberately to make use of it. But it will help anyone using the standalone.

YOU54F commented 1 year ago

good point Polly the party pooper 😂

We can provide guidance to users to either mount their env vars into the container, so they will be picked up

https://github.com/pactflow/actions/pull/14