Open YOU54F opened 7 months ago
Using GitHub's container registry is great.
It would be good to document the change from an end-user perspective. If I used to docker run --rm pactfoundation/foo
, what do I run now?
agree
docker pull ghcr.io/pact-foundation/pact-cli:latest
docker pull ghcr.io/pact-foundation/pact-broker:latest
the org changes from non hyphenated to hyphenated pact-foundation
a user may need to login to ghcr registry with their docker client
Now complete
docker pull pactfoundation/pact-stub-server
docker run -t -p 8080:8080 -v "$(pwd)/pacts/:/app/pacts" pactfoundation/pact-stub-server -p 8080 -d pacts
docker pull ghcr.io/pact-foundation/pact-stub-server
docker run -t -p 8080:8080 -v "$(pwd)/pacts/:/app/pacts" ghcr.io/pact-foundation/pact-stub-server -p 8080 -d pacts
Can this also be implemented for the pact-ref-verifier image from the pact-reference repository? I noticed that recent versions from that repo haven't been pushed to any registry (see pact-foundation/pact-reference#446).
yep sorry haven't got round to adding an auto publish to docker for the verifier and mock server cli. will look to get in place possibly next week
In order to avoid users who may be affected by rate limiting pulling images from DockerHub, it would be prudent to provide images published to GHCR
Dockerhub profile :- https://hub.docker.com/u/pactfoundation
Images / Repos and Build locations
Delta of required changes
https://github.com/pact-foundation/pact-ruby-cli/pull/127/files
Progress