pactflow / docs.pactflow.io

Pactflow technical documentation
Other
6 stars 13 forks source link

snag: doc sync failing since org setup with sso #291

Closed YOU54F closed 4 months ago

YOU54F commented 5 months ago

Issue 1 : PAT tokens require SSO

From triggering job

https://github.com/pactflow/example-provider-dotnet/actions/runs/9223404200/job/25376545105

{
  "message": "Resource protected by organization SAML enforcement. You must grant your Personal Access token access to this organization.",
  "documentation_url": "https://docs.github.com/articles/authenticating-to-a-github-organization-with-saml-single-sign-on/"
}

Issue 2: Main branch in docs is now write-protected, and as such the docs sync fails, as it attempts to write to master.

https://github.com/pactflow/docs.pactflow.io/actions/runs/9223601246/job/25377172271

Error: Error: To https://github.com/pactflow/docs.pactflow.io
!   refs/heads/master:refs/heads/master [remote rejected] (protected branch hook declined)
Done
Pushing to https://github.com/pactflow/docs.pactflow.io
POST git-receive-pack (1007 bytes)
remote: error: GH006: Protected branch update failed for refs/heads/master.        
remote: error: Changes must be made through a pull request.        
error: failed to push some refs to 'https://github.com/pactflow/docs.pactflow.io'

Need to relax for this job, or have this job write to a new branch and open a PR

YOU54F commented 5 months ago

To fix issue 2, raise PR on new branch after doc sync

https://github.com/pactflow/docs.pactflow.io/pull/292

manually triggered doc sync for event all-docs-updated against the above branch

https://github.com/pactflow/docs.pactflow.io/tree/all-docs-updated

PR with updated docs

https://github.com/pactflow/docs.pactflow.io/pull/293

JP-Ellis commented 5 months ago

I see the two linked issues have been merged, I think this issue can be closed?

YOU54F commented 4 months ago

yep yep